Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): add plain modifier to toggle button #3140

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Oct 14, 2019

#3128

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 14, 2019

PatternFly-React preview: https://patternfly-react-pr-3140.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #3140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3140   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23535    23535           
  Branches     1877     1877           
=======================================
  Hits        16246    16246           
  Misses       6336     6336           
  Partials      953      953
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.11% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/Select/SelectToggle.tsx 60.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3ad74...e21852e. Read the comment docs.

@boaz0
boaz0 approved these changes Oct 15, 2019
Copy link
Member

boaz0 left a comment

code LGTM

@mcoker
mcoker approved these changes Oct 21, 2019
Copy link
Contributor

mcoker left a comment

LGTM!!

@dlabaj
dlabaj approved these changes Oct 22, 2019
@dlabaj dlabaj merged commit 6dda90a into patternfly:master Oct 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.