Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCustom row wrapper example for table #3160
Conversation
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-3160.surge.sh |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 17, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
- Coverage 69.03% 69.02% -0.02%
==========================================
Files 859 858 -1
Lines 23637 23623 -14
Branches 1895 1892 -3
==========================================
- Hits 16318 16305 -13
Misses 6359 6359
+ Partials 960 959 -1
Continue to review full report at Codecov.
|
|
The table example looks good, but see code for a table demo and table example. Do we need both? |
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
...ation/demo-app-ts/src/components/demos/TableDemo/TableRowWrapperDemo.tsx
Show resolved
Hide resolved
seanforyou23
force-pushed the
seanforyou23:row-wrapper-demo
branch
from
345f71a
to
5b09de0
seanforyou23
changed the title
seanforyou23
force-pushed the
seanforyou23:row-wrapper-demo
branch
from
70e74d8
to
6d7d0e7
seanforyou23
force-pushed the
seanforyou23:row-wrapper-demo
branch
from
540b00a
to
9ff002b
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-table/src/components/Table/Table.md
Outdated
Show resolved
Hide resolved
...s/patternfly-4/react-table/src/components/Table/demo/CustomRowWrapper.js
Outdated
Show resolved
Hide resolved
...p-ts/src/components/demos/TableDemo/RowWrapperForTableRowWrapperDemo.tsx
Outdated
Show resolved
Hide resolved
… example remove unused imports from examples improve type for rowProps ensure rowwrapper example works in typescript clear some lint errors
seanforyou23
force-pushed the
seanforyou23:row-wrapper-demo
branch
from
0ab74d1
to
7d7161d
This comment has been minimized.
This comment has been minimized.
|
Thanks for the feedback! I've rebased with master and just waiting on the docs to finish building. I introduced one more change which I think will be helpful but needs to be tested further. Let me know what you think! |
This comment has been minimized.
This comment has been minimized.
|
@jenny-s51 I see you requested changes. Do you want to review, again? |
|
LGTM @seanforyou23 |
This comment has been minimized.
This comment has been minimized.
|
Your changes have been released in:
Thanks for your contribution! |
seanforyou23 commentedOct 17, 2019
•
edited
What: This PR adds an example for how to customize a row wapper in table. Also registers the example with react-integration.
Additional issues: #3121 and #3018 and #3118
I built off the top of @priley86 's initial example of how custom classes per row can be achieved.
It also clears a few console errors for table examples that were introduced recently.