Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom row wrapper example for table #3160

Merged
merged 2 commits into from Oct 23, 2019

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented Oct 17, 2019

What: This PR adds an example for how to customize a row wapper in table. Also registers the example with react-integration.

Screen Shot 2019-10-17 at 7 24 04 PM

Additional issues: #3121 and #3018 and #3118

I built off the top of @priley86 's initial example of how custom classes per row can be achieved.

It also clears a few console errors for table examples that were introduced recently.

Screen Shot 2019-10-17 at 5 31 08 PM

Screen Shot 2019-10-17 at 5 31 17 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 17, 2019

PatternFly-React preview: https://patternfly-react-pr-3160.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #3160 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
- Coverage   69.03%   69.02%   -0.02%     
==========================================
  Files         859      858       -1     
  Lines       23637    23623      -14     
  Branches     1895     1892       -3     
==========================================
- Hits        16318    16305      -13     
  Misses       6359     6359              
+ Partials      960      959       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 68.02% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 91.35% <100%> (ø) ⬆️
...-4/react-table/src/components/Table/RowWrapper.tsx 78% <100%> (ø) ⬆️
...re/src/experimental/components/Divider/Divider.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0defa...7d7161d. Read the comment docs.

Copy link
Member

dlabrecq left a comment

The table example looks good, but see code for a table demo and table example. Do we need both?

@seanforyou23 seanforyou23 force-pushed the seanforyou23:row-wrapper-demo branch from 345f71a to 5b09de0 Oct 18, 2019
@seanforyou23 seanforyou23 changed the title Custom row wrapper demo for table Custom row wrapper example for table Oct 18, 2019
@seanforyou23 seanforyou23 force-pushed the seanforyou23:row-wrapper-demo branch from 70e74d8 to 6d7d0e7 Oct 18, 2019
@seanforyou23 seanforyou23 requested a review from dlabrecq Oct 18, 2019
@seanforyou23 seanforyou23 force-pushed the seanforyou23:row-wrapper-demo branch from 540b00a to 9ff002b Oct 18, 2019
… example

remove unused imports from examples
improve type for rowProps
ensure rowwrapper example works in typescript
clear some lint errors
@seanforyou23 seanforyou23 force-pushed the seanforyou23:row-wrapper-demo branch from 0ab74d1 to 7d7161d Oct 22, 2019
@seanforyou23 seanforyou23 requested a review from jenny-s51 Oct 22, 2019
@seanforyou23

This comment has been minimized.

Copy link
Member Author

seanforyou23 commented Oct 22, 2019

Thanks for the feedback! I've rebased with master and just waiting on the docs to finish building. I introduced one more change which I think will be helpful but needs to be tested further. Let me know what you think!

@dlabrecq

This comment has been minimized.

Copy link
Member

dlabrecq commented Oct 23, 2019

@jenny-s51 I see you requested changes. Do you want to review, again?

Copy link
Contributor

jenny-s51 left a comment

LGTM @seanforyou23 🙂

@dlabrecq dlabrecq merged commit f96bda8 into patternfly:master Oct 23, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 23, 2019

Your changes have been released in:

  • @patternfly/react-core@3.118.0
  • @patternfly/react-docs@4.15.6
  • @patternfly/react-inline-edit-extension@2.12.6
  • demo-app-ts@3.8.0
  • @patternfly/react-integration@3.8.0
  • @patternfly/react-table@2.24.6
  • @patternfly/react-topology@2.10.6
  • @patternfly/react-virtualized-extension@1.3.6

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.