Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(emptyState): remove debug message from tests #3161

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Oct 18, 2019

What:

small nitpick - removing unnecessary debug log in the empty state tests (that I added and forgot to remove 馃槺 )

issue: #3165
closes #3165

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #3161 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   68.98%   68.98%   -0.01%     
==========================================
  Files         858      858              
  Lines       23627    23621       -6     
  Branches     1893     1889       -4     
==========================================
- Hits        16300    16294       -6     
  Misses       6366     6366              
  Partials      961      961
Flag Coverage 螖
#misc 95.45% <酶> (酶) 猬嗭笍
#patternfly3 69.3% <酶> (酶) 猬嗭笍
#patternfly4 67.93% <酶> (-0.02%) 猬囷笍
Impacted Files Coverage 螖
...-4/react-core/src/components/withOuia/withOuia.tsx 76.92% <0%> (-1.65%) 猬囷笍
...ernfly-4/react-table/src/components/Table/Body.tsx 72.34% <0%> (-0.58%) 猬囷笍
...-4/react-table/src/components/Table/RowWrapper.tsx 77.55% <0%> (-0.45%) 猬囷笍
...rnfly-4/react-table/src/components/Table/Table.tsx 91.35% <0%> (酶) 猬嗭笍
...y-3/patternfly-react/src/components/Table/Table.js 95.74% <0%> (酶) 猬嗭笍
...omponents/Table/utils/decorators/cellHeightAuto.ts 100% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3a965e4...f7c3f90. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 18, 2019

PatternFly-React preview: https://patternfly-react-pr-3161.surge.sh

@tlabaj
tlabaj approved these changes Oct 18, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj added the chore 馃彔 label Oct 18, 2019
@tlabaj tlabaj merged commit 375b688 into patternfly:master Oct 21, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 21, 2019

Your changes have been released in:

  • @patternfly/react-core@3.117.3
  • @patternfly/react-docs@4.15.3
  • @patternfly/react-inline-edit-extension@2.12.3
  • demo-app-ts@3.7.17
  • @patternfly/react-table@2.24.3
  • @patternfly/react-topology@2.10.3
  • @patternfly/react-virtualized-extension@1.3.3

Thanks for your contribution! 馃帀

@boaz0 boaz0 deleted the boaz0:remove_debug_from_empty_state_test branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.