Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upchore(emptyState): remove debug message from tests #3161
Merged
Conversation
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 18, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
==========================================
- Coverage 68.98% 68.98% -0.01%
==========================================
Files 858 858
Lines 23627 23621 -6
Branches 1893 1889 -4
==========================================
- Hits 16300 16294 -6
Misses 6366 6366
Partials 961 961
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
PatternFly-React preview: https://patternfly-react-pr-3161.surge.sh |
LGTM |
This comment has been minimized.
This comment has been minimized.
Your changes have been released in:
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
boaz0 commentedOct 18, 2019
•
edited
What:
small nitpick - removing unnecessary debug log in the empty state tests (that I added and forgot to remove😱 )
issue: #3165
closes #3165