Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(copytoclipboard): wrap pre inside the expand element #3169

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Oct 20, 2019

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 20, 2019

PatternFly-React preview: https://patternfly-react-pr-3169.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #3169 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
+ Coverage   68.98%   68.99%   +<.01%     
==========================================
  Files         858      858              
  Lines       23627    23623       -4     
  Branches     1893     1892       -1     
==========================================
- Hits        16300    16299       -1     
+ Misses       6366     6365       -1     
+ Partials      961      959       -2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 67.96% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...components/ClipboardCopy/ClipboardCopyExpanded.tsx 84.61% <100%> (+14.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5447bb9...f9a08c1. Read the comment docs.

@christiemolloy christiemolloy requested review from jessiehuff, jenny-s51 and christiemolloy and removed request for jessiehuff Oct 21, 2019
Copy link
Member

christiemolloy left a comment

This looks great!! Thank you so much for implementing this @boaz0

@dlabaj
dlabaj approved these changes Oct 21, 2019
@dlabaj
dlabaj approved these changes Oct 21, 2019
@dlabaj dlabaj merged commit b89f1d3 into patternfly:master Oct 21, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 21, 2019

Your changes have been released in:

  • patternfly-react-extensions@3.0.2
  • patternfly-react@2.39.6
  • @patternfly/react-console@2.0.2
  • @patternfly/react-core@3.117.2
  • @patternfly/react-docs@4.15.2
  • @patternfly/react-inline-edit-extension@2.12.2
  • demo-app-ts@3.7.16
  • @patternfly/react-table@2.24.2
  • @patternfly/react-topology@2.10.2
  • @patternfly/react-virtualized-extension@1.3.2

Thanks for your contribution! 🎉

@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Oct 21, 2019

Thank you all!

@boaz0 boaz0 deleted the boaz0:closes_3163 branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.