Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surround ouia check with a try catch #3178

Merged
merged 1 commit into from Oct 22, 2019
Merged

Conversation

@jschuler
Copy link
Collaborator

jschuler commented Oct 22, 2019

add try/catch to the ouia check since there are some environments were simply checking for window.localStorage can throw a security exception

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #3178 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   68.99%   68.99%   -0.01%     
==========================================
  Files         858      858              
  Lines       23623    23625       +2     
  Branches     1892     1892              
==========================================
+ Hits        16299    16300       +1     
- Misses       6365     6366       +1     
  Partials      959      959
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 67.96% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...rnfly-4/react-core/src/components/withOuia/ouia.ts 62.5% <50%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681751...1ff73da. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 22, 2019

PatternFly-React preview: https://patternfly-react-pr-3178.surge.sh

@redallen redallen merged commit 1d656ad into patternfly:master Oct 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 22, 2019

Your changes have been released in:

  • @patternfly/react-core@3.117.4
  • @patternfly/react-docs@4.15.4
  • @patternfly/react-inline-edit-extension@2.12.4
  • demo-app-ts@3.7.18
  • @patternfly/react-table@2.24.4
  • @patternfly/react-topology@2.10.4
  • @patternfly/react-virtualized-extension@1.3.4

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.