Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextArea): Add a prop to allow limiting the resize orientation o… #3180

Merged
merged 2 commits into from Oct 24, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Oct 22, 2019

…f the TextAres

#2839

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 22, 2019

PatternFly-React preview: https://patternfly-react-pr-3180.surge.sh

Titani
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 22, 2019

PatternFly-React preview: https://patternfly-react-pr-3180.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #3180 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   68.99%   68.99%   +<.01%     
==========================================
  Files         858      858              
  Lines       23625    23633       +8     
  Branches     1892     1894       +2     
==========================================
+ Hits        16300    16306       +6     
  Misses       6366     6366              
- Partials      959      961       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 67.96% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...-4/react-core/src/components/TextArea/TextArea.tsx 95.45% <100%> (+1.7%) ⬆️
...components/ClipboardCopy/ClipboardCopyExpanded.tsx 70.58% <0%> (-14.03%) ⬇️
...rnfly-4/react-core/src/components/withOuia/ouia.ts 66.66% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ee9f7...3f4a1b4. Read the comment docs.

Copy link
Member

christiemolloy left a comment

LGTM!

@dlabaj
dlabaj approved these changes Oct 24, 2019
Copy link
Contributor

dlabaj left a comment

Good job.

@dlabaj dlabaj merged commit d61ae9d into patternfly:master Oct 24, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 24, 2019

Your changes have been released in:

  • @patternfly/react-core@3.119.0
  • @patternfly/react-docs@4.15.8
  • @patternfly/react-inline-edit-extension@2.12.8
  • demo-app-ts@3.9.0
  • @patternfly/react-integration@3.9.0
  • @patternfly/react-table@2.24.8
  • @patternfly/react-topology@2.10.8
  • @patternfly/react-virtualized-extension@1.3.8

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.