Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Select): update prop description for selctions #3183

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Oct 22, 2019

#3106

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 22, 2019

PatternFly-React preview: https://patternfly-react-pr-3183.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #3183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files         859      859           
  Lines       23637    23637           
  Branches     1895     1895           
=======================================
  Hits        16318    16318           
  Misses       6359     6359           
  Partials      960      960
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 68.05% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 61.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0defa...5f1a175. Read the comment docs.

Copy link
Contributor

evwilkin left a comment

LGTM

@kmcfaul kmcfaul merged commit 2da4c48 into patternfly:master Oct 24, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 24, 2019

Your changes have been released in:

  • @patternfly/react-core@3.118.1
  • @patternfly/react-docs@4.15.7
  • @patternfly/react-inline-edit-extension@2.12.7
  • demo-app-ts@3.8.1
  • @patternfly/react-table@2.24.7
  • @patternfly/react-topology@2.10.7
  • @patternfly/react-virtualized-extension@1.3.7

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.