Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DataToolbar): add unit and integration tests #3201

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Oct 24, 2019

addresses #3017

@nicolethoen nicolethoen requested review from rebeccaalpert, tlabaj and kmcfaul Oct 24, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 24, 2019

PatternFly-React preview: https://patternfly-react-pr-3201.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #3201 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3201      +/-   ##
==========================================
+ Coverage   69.13%   69.23%   +0.09%     
==========================================
  Files         868      869       +1     
  Lines       23780    23873      +93     
  Branches     1935     1927       -8     
==========================================
+ Hits        16441    16529      +88     
- Misses       6360     6361       +1     
- Partials      979      983       +4
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 68.52% <ø> (+0.22%) ⬆️
Impacted Files Coverage Δ
...onents/DataToolbar/DataToolbarChipGroupContent.tsx 81.81% <ø> (ø)
...-4/react-core/src/components/TextArea/TextArea.tsx 93.75% <0%> (-1.71%) ⬇️
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84.48% <0%> (-0.27%) ⬇️
...patternfly-react/src/components/Tooltip/Tooltip.js 94.18% <0%> (-0.07%) ⬇️
...-4/react-table/src/components/Table/RowWrapper.tsx 78% <0%> (ø) ⬆️
...tension/src/components/CatalogTile/CatalogTile.tsx
...nsion/src/components/VerticalTabs/VerticalTabs.tsx
...rc/components/PropertiesSidePanel/PropertyItem.tsx
...onents/PropertiesSidePanel/PropertiesSidePanel.tsx
...on/src/components/CatalogTile/CatalogTileBadge.tsx
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df491ae...44e0880. Read the comment docs.

@nicolethoen nicolethoen requested a review from evwilkin Oct 25, 2019
Copy link
Contributor

dlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Oct 25, 2019
@tlabaj
tlabaj approved these changes Oct 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 1022897 into patternfly:master Oct 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.