Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @patternfly/patternfly versions to 2.40.2 #3204

Merged
merged 5 commits into from Oct 25, 2019
Merged

Conversation

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 24, 2019

What: Bump @patternfly/patternfly versions to 2.40.2

Additional issues: I'm a bot.
#3207

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #3204 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
- Coverage   69.13%   69.13%   -0.01%     
==========================================
  Files         868      868              
  Lines       23780    23777       -3     
  Branches     1935     1932       -3     
==========================================
- Hits        16441    16438       -3     
  Misses       6360     6360              
  Partials      979      979
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 68.29% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...al/components/OverflowMenu/OverflowMenuControl.tsx 100% <ø> (ø) ⬆️
...ental/components/OverflowMenu/OverflowMenuItem.tsx 100% <ø> (ø) ⬆️
...ntal/components/OverflowMenu/OverflowMenuGroup.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b3a6d...ab5ce3d. Read the comment docs.

@tlabaj tlabaj removed the Do Not Merge label Oct 25, 2019
DropdownItems read from isShared and from context to conditionally render.
@evwilkin evwilkin dismissed stale reviews from mcoker, mattnolting, and jeff-phillips-18 via c83cda0 Oct 25, 2019
evwilkin added 2 commits Oct 25, 2019
Copy link
Contributor

evwilkin left a comment

LGTM

Copy link
Contributor

mattnolting left a comment

LGTM 👍

@dlabaj
dlabaj approved these changes Oct 25, 2019
@dlabaj dlabaj merged commit 672047a into master Oct 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.