Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optionmenu): remove the i element around selected item svg #3238

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Oct 30, 2019

What:

closes #3229

//cc @mcoker

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 30, 2019

PatternFly-React preview: https://patternfly-react-pr-3238.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #3238 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   67.43%   67.43%   -0.01%     
==========================================
  Files         892      892              
  Lines       24874    24875       +1     
  Branches     2141     2142       +1     
==========================================
  Hits        16775    16775              
  Misses       7094     7094              
- Partials     1005     1006       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.76% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ore/src/components/OptionsMenu/OptionsMenuItem.tsx 62.5% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269a6f0...4ef0bb3. Read the comment docs.

@mcoker
mcoker approved these changes Oct 30, 2019
Copy link
Contributor

mcoker left a comment

lgtm! thanks @boaz0

@tlabaj
tlabaj approved these changes Nov 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 5991033 into patternfly:master Nov 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 5, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.7
  • @patternfly/react-core@3.120.6
  • @patternfly/react-docs@4.16.11
  • @patternfly/react-inline-edit-extension@2.12.18
  • demo-app-ts@3.9.7
  • @patternfly/react-table@2.24.18
  • @patternfly/react-topology@2.11.6
  • @patternfly/react-virtualized-extension@1.3.18

Thanks for your contribution! 🎉

@boaz0 boaz0 deleted the boaz0:closes_3229 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.