Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(package.json): Upgrade react-bootstrap to fix React deprecated lifecycle method warnings #3249

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@mturley
Copy link
Collaborator

mturley commented Oct 30, 2019

What:

Fixes #3010
In order to prevent React's warnings about deprecated lifecycle methods, and allow consumers who use Patternfly 3 components to eventually upgrade to React 17, I am upgrading our version of react-bootstrap to take their fixes for react-bootstrap/react-bootstrap#4398.

Additional issues:

Once released, this will unblock ManageIQ/manageiq-v2v#1037.

We should do a once-over to make sure all affected PF3 components are still behaving as expected, especially since some of the snapshots changed.

@mturley mturley added the PF3 label Oct 30, 2019
@mturley mturley changed the title build(package.json): Upgrade react-bootstrap to fix React lifecycle methods build(package.json): Upgrade react-bootstrap to fix React lifecycle method warnings Oct 30, 2019
@mturley mturley changed the title build(package.json): Upgrade react-bootstrap to fix React lifecycle method warnings build(package.json): Upgrade react-bootstrap to fix React deprecated lifecycle method warnings Oct 30, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #3249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3249   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8ea98...e26d4df. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 30, 2019

PatternFly-React preview: https://patternfly-react-pr-3249.surge.sh

@mturley mturley force-pushed the mturley:3010-fix-lifecycle-warnings branch from 6d5d402 to 6b36dd8 Oct 30, 2019
Copy link
Member

boaz0 left a comment

LGTM 👍

Copy link
Contributor

redallen left a comment

Thanks!

@mturley

This comment has been minimized.

Copy link
Collaborator Author

mturley commented Nov 4, 2019

Looks like this needs fixes to our in-house components, too. Don't merge just yet. #3010 (comment)

@mturley

This comment has been minimized.

Copy link
Collaborator Author

mturley commented Nov 4, 2019

Scratch that last comment, #3098 resolved the issues @martinpovolny identified. This should be good to merge. I'll give it a rebase now.

@mturley mturley dismissed stale reviews from redallen and boaz0 via e26d4df Nov 4, 2019
@mturley mturley force-pushed the mturley:3010-fix-lifecycle-warnings branch from 6b36dd8 to e26d4df Nov 4, 2019
@mturley

This comment has been minimized.

Copy link
Collaborator Author

mturley commented Nov 4, 2019

Rebased. @redallen could you re-approve?

@tlabaj
tlabaj approved these changes Nov 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 0185bc5 into patternfly:master Nov 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@mturley mturley deleted the mturley:3010-fix-lifecycle-warnings branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.