Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add new package to promotion script #3260

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Nov 4, 2019

What: Just a little build fix I'd like to commit upstream that makes my life easier to promote packages. No associated issue.

Additional issues: Closes #3322

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 4, 2019

PatternFly-React preview: https://patternfly-react-pr-3260.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #3260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3260   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8ea98...920ad02. Read the comment docs.

@redallen redallen requested a review from tlabaj Nov 11, 2019
@tlabaj
tlabaj approved these changes Nov 19, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 15d8053 into patternfly:master Nov 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.