Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): update github templates #3261

Merged
merged 2 commits into from Nov 13, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Nov 4, 2019

What: Closes #2952

Additional issues: I did change some of the text of these templates to make them consistent.

  1. I removed the long first block comment in PULL_REQUEST_TEMPLATE.md and the <!-- feel free to add additional comments --> to stay consistent with our new ISSUE_TEMPLATE.md.
  2. I changed our ISSUE_TEMPLATE.md to use bold text for it's questions rather than headers like #### to be consistent with our PULL_REQUEST_TEMPLATE.md.
  3. In order to close #2952, I changed the first question in PULL_REQUEST_TEMPLATE.md to
<!-- What changes are being made? Please link the issue being addressed. -->
**What**: Closes #

from

<!-- What changes are being made? (What issue is being addressed here?) -->

**What**:

The extra line breaks are unnecessary and we should ask that they link an issue per #2952.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #3261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3261   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8ea98...cd1c40e. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 4, 2019

PatternFly-React preview: https://patternfly-react-pr-3261.surge.sh

@tlabaj tlabaj self-assigned this Nov 5, 2019
@tlabaj tlabaj requested a review from dlabaj Nov 5, 2019
Copy link
Member

dlabrecq left a comment

LGTM

Copy link
Member

boaz0 left a comment

LGTM 👍

@dlabaj
dlabaj approved these changes Nov 13, 2019
@dlabaj dlabaj merged commit 093458b into patternfly:master Nov 13, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.