Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav & pagelayout): removes basic nav example, switches to default variant, updates PF masthead logo #3262

Merged
merged 12 commits into from Dec 2, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Nov 5, 2019

Closes #3044

…variant, updates PF masthead logo
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2415a94). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3262   +/-   ##
=========================================
  Coverage          ?   67.44%           
=========================================
  Files             ?      892           
  Lines             ?    24873           
  Branches          ?     2141           
=========================================
  Hits              ?    16775           
  Misses            ?     7093           
  Partials          ?     1005
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.77% <ø> (?)
Impacted Files Coverage Δ
...rnfly-4/react-core/src/components/Nav/NavGroup.tsx 72.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415a94...55ef878. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 5, 2019

PatternFly-React preview: https://patternfly-react-pr-3262.surge.sh

@tlabaj tlabaj requested review from mcoker and jschuler Nov 5, 2019
@tlabaj tlabaj added the css review label Nov 5, 2019
@tlabaj tlabaj requested a review from jessiehuff Nov 5, 2019
@@ -15,7 +15,7 @@
</button>
</div>
<a class="pf-c-page__header-brand-link" href="#">
<img class="pf-c-brand pf-m-sm" src="https://pf4.patternfly.org/assets/images/l_pf-reverse-164x11.png" alt="Patternfly Logo" />
<img class="pf-c-brand pf-m-sm" src="https://pf4.patternfly.org/assets/images/PF-Masthead-Logo.svg" alt="Patternfly Logo" />

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Nov 5, 2019

Member

Curious how this image is being used? I don't see it in the live page source

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Nov 8, 2019

Author Contributor

@dlabrecq This is how the new logo is used when I open .circleci/index.html in my browser:
Screen Shot 2019-11-08 at 12 32 28 PM

@jenny-s51 jenny-s51 force-pushed the jenny-s51:iss3044 branch from 9178902 to 2b66439 Nov 8, 2019
@jenny-s51 jenny-s51 requested review from boaz0 and dlabrecq Nov 8, 2019
@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Nov 18, 2019

Hey @jenny-s51 looks great! I missed one spot in the original issue - on https://patternfly-react-pr-3262.surge.sh/patternfly-4/documentation/react/demos/pagelayout, we need to remove the first (basic nav) example

@@ -25,6 +25,6 @@ export const NavGroup: React.FunctionComponent<NavGroupProps> = ({
<h2 className={css(styles.navSectionTitle)} id={id}>
{title}
</h2>
<ul className={css(styles.navSimpleList)}>{children}</ul>
<ul className={css(styles.navList)}>{children}</ul>

This comment has been minimized.

Copy link
@redallen
Copy link
Contributor

mcoker left a comment

🥇

@jenny-s51 jenny-s51 force-pushed the jenny-s51:iss3044 branch from 29efbdc to e7f00d2 Nov 19, 2019
Copy link
Contributor

tlabaj left a comment

Can you move the default example above the Grouped example please.

@jenny-s51 jenny-s51 requested review from tlabaj, mcoker and redallen Nov 21, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Nov 21, 2019

@jenny-s51 sorry I missed one spot - can you also update the legacy/light nav page demo to use the default nav instead of the simple nav?

@jenny-s51 jenny-s51 dismissed stale reviews from kmcfaul, tlabaj, and redallen via 55ef878 Nov 22, 2019
@jenny-s51 jenny-s51 requested review from tlabaj, kmcfaul and redallen Nov 22, 2019
@mcoker
mcoker approved these changes Nov 22, 2019
Copy link
Contributor

mcoker left a comment

👍

@tlabaj
tlabaj approved these changes Nov 26, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit fe707a3 into patternfly:master Dec 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.