Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog-view-extension): check for sass changes #3271

Merged

Conversation

@redallen
Copy link
Contributor

redallen commented Nov 6, 2019

What: Fix bug reported by @jcaianirh where the extension wasn't rebuilt after #3236

Additional issues:

Copy link
Contributor

jcaianirh left a comment

lgtm

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 6, 2019

PatternFly-React preview: https://patternfly-react-pr-3271.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #3271 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   67.43%   67.43%   -0.01%     
==========================================
  Files         892      892              
  Lines       24870    24869       -1     
  Branches     2141     2140       -1     
==========================================
- Hits        16771    16770       -1     
  Misses       7094     7094              
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ernfly-4/react-table/src/components/Table/Body.tsx 72.91% <0%> (-2.09%) ⬇️
...ore/src/components/OptionsMenu/OptionsMenuItem.tsx 66.66% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d89d9...e227026. Read the comment docs.

@jcaianirh jcaianirh merged commit 3efa4e3 into patternfly:master Nov 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 6, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.9
  • @patternfly/react-docs@4.16.13

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.