Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-catalog-extension): fix @types errors when using the extension #3284

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@jcaianirh
Copy link
Contributor

jcaianirh commented Nov 7, 2019

What: errors occur when using the extension due to @types/react...specify versions in package.json

Additional issues:

errors occur when using the extension due to @types/react
@jcaianirh jcaianirh requested a review from rebeccaalpert Nov 7, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3284.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #3284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3284   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         892      892           
  Lines       24867    24867           
  Branches     2141     2141           
=======================================
  Hits        16772    16772           
  Misses       7091     7091           
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3a124...dff7a6d. Read the comment docs.

@rebeccaalpert rebeccaalpert merged commit eda18c1 into patternfly:master Nov 7, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 7, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.13
  • @patternfly/react-docs@4.16.18

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.