Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CatalogTile): Removed margin and fixed hidden text #3285

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Nov 7, 2019

Updated margins per design feedback and fixed hidden text bug.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #3285 into master will increase coverage by 2.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
+ Coverage   64.78%   67.44%   +2.66%     
==========================================
  Files         481      892     +411     
  Lines       11699    24867   +13168     
  Branches     2141     2141              
==========================================
+ Hits         7579    16772    +9193     
- Misses       3116     7091    +3975     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.3% <ø> (?)
#patternfly4 64.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...patternfly-react/src/components/Spinner/Spinner.js 64.51% <0%> (-35.49%) ⬇️
...y-3/patternfly-react/src/components/Badge/index.js 62.5% <0%> (-20.84%) ⬇️
...-3/patternfly-react/src/components/Switch/index.js 62.5% <0%> (-20.84%) ⬇️
...patternfly-react/src/components/Toolbar/Toolbar.js 83.05% <0%> (-16.95%) ⬇️
...-3/patternfly-react/src/components/Button/index.js 88.23% <0%> (-11.77%) ⬇️
...ly-3/patternfly-react/src/components/Tabs/index.js 71.42% <0%> (-9.83%) ⬇️
...atternfly-react/src/components/Breadcrumb/index.js 72.22% <0%> (-9.03%) ⬇️
...ernfly-react/src/components/Wizard/WizardFooter.js 77.41% <0%> (-8.3%) ⬇️
...ponents/ApplicationLauncher/ApplicationLauncher.js 90.66% <0%> (-3.22%) ⬇️
...fly-3/patternfly-react/src/components/Nav/index.js 77.5% <0%> (-3.06%) ⬇️
... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3884f34...ca48b14. Read the comment docs.

Copy link
Contributor

jcaianirh left a comment

lgtm

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:catalogtileedits branch from 6df12ba to 93a5741 Nov 7, 2019
Copy link
Contributor

jcaianirh left a comment

lgtm

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:catalogtileedits branch from 93a5741 to c6143f8 Nov 7, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:catalogtileedits branch from c6143f8 to ca48b14 Nov 7, 2019
Copy link
Contributor

jcaianirh left a comment

lgtm

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 8, 2019

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

@jcaianirh jcaianirh merged commit 4028a8c into patternfly:master Nov 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 8, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.15
  • @patternfly/react-docs@4.16.20

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.