Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyboard interaction for dropdown #3293

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Nov 8, 2019

Fixed Dropdown a11y keyboard interaction and created cypress a11y/integration tests

Fixes #3210
Fixes #1849

Preview link: http://pf4-dropdown-accessibility.surge.sh/

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #3293 into master will increase coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3293      +/-   ##
==========================================
+ Coverage   67.44%   67.44%   +<.01%     
==========================================
  Files         892      892              
  Lines       24867    24865       -2     
  Branches     2141     2136       -5     
==========================================
- Hits        16772    16771       -1     
+ Misses       7091     7089       -2     
- Partials     1004     1005       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.78% <10%> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/Dropdown/DropdownMenu.tsx 51.85% <0%> (+4.39%) ⬆️
...e/src/components/Dropdown/InternalDropdownItem.tsx 73.61% <16.66%> (+0.37%) ⬆️
...rnfly-4/react-table/src/test-helpers/data-sets.tsx 40% <0%> (-17.15%) ⬇️
...rc/components/Table/utils/decorators/headerCol.tsx 50% <0%> (-16.67%) ⬇️
...ernfly-4/react-table/src/components/Table/Body.tsx 72.91% <0%> (-2.09%) ⬇️
...src/components/Table/utils/decorators/wrappable.ts 100% <0%> (ø) ⬆️
.../components/Table/utils/decorators/cellActions.tsx 100% <0%> (ø) ⬆️
...rc/components/Table/utils/decorators/classNames.ts 100% <0%> (ø) ⬆️
...src/components/Table/utils/decorators/cellWidth.ts 100% <0%> (ø) ⬆️
...rc/components/Table/utils/decorators/textCenter.ts 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d0285...d8c877d. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 8, 2019

PatternFly-React preview: https://patternfly-react-pr-3293.surge.sh

@tlabaj
tlabaj approved these changes Nov 19, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit f70c00f into patternfly:master Nov 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 19, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.25
  • @patternfly/react-charts@5.2.0
  • @patternfly/react-core@3.120.16
  • @patternfly/react-docs@4.16.31
  • @patternfly/react-inline-edit-extension@2.12.30
  • demo-app-ts@3.9.19
  • @patternfly/react-integration@3.9.4
  • @patternfly/react-table@2.24.30
  • @patternfly/react-topology@2.11.16
  • @patternfly/react-virtualized-extension@1.3.29

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.