Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): fixed previous page navigation issues with 1 row perpage #3297

Merged
merged 3 commits into from Nov 15, 2019

Conversation

@evwilkin
Copy link
Contributor

evwilkin commented Nov 11, 2019

What:
fixes #3087

Additional issues:

@evwilkin evwilkin requested a review from seanforyou23 Nov 11, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 11, 2019

PatternFly-React preview: https://patternfly-react-pr-3297.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #3297 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files         892      892              
  Lines       24867    24867              
  Branches     2141     2141              
==========================================
- Hits        16772    16771       -1     
  Misses       7091     7091              
- Partials     1004     1005       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.77% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...eact-core/src/components/Pagination/Pagination.tsx 82.53% <100%> (ø) ⬆️
...eact-core/src/components/Pagination/Navigation.tsx 85.88% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bf30c...ef25e58. Read the comment docs.

Copy link
Contributor

redallen left a comment

What about these lines?

<ToggleTemplate
            firstIndex={firstIndex}
            lastIndex={lastIndex}
            itemCount={itemCount}
            itemsTitle={titles.items}
/>
@evwilkin

This comment has been minimized.

Copy link
Contributor Author

evwilkin commented Nov 15, 2019

What about these lines?

<ToggleTemplate
            firstIndex={firstIndex}
            lastIndex={lastIndex}
            itemCount={itemCount}
            itemsTitle={titles.items}
/>

@redallen thanks for taking a look - those lines shouldn't affect this navigation issue, unless we wanted to change the text displayed on the page.

Copy link
Contributor

redallen left a comment

You explained what firstIndex actually is, so this looks good!

@redallen redallen merged commit 300d828 into patternfly:master Nov 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 15, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.20
  • @patternfly/react-core@3.120.11
  • @patternfly/react-docs@4.16.25
  • @patternfly/react-inline-edit-extension@2.12.25
  • demo-app-ts@3.9.14
  • @patternfly/react-table@2.24.25
  • @patternfly/react-topology@2.11.11
  • @patternfly/react-virtualized-extension@1.3.24

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.