Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): remove form typeahead and checkbox selects #3298

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Nov 12, 2019

Addresses #3288

@nicolethoen nicolethoen requested review from mcoker, tlabaj and kmcfaul Nov 12, 2019
@nicolethoen nicolethoen force-pushed the nicolethoen:select_remove_form branch from f438793 to 95e9f97 Nov 12, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #3298 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
+ Coverage   67.44%   67.46%   +0.01%     
==========================================
  Files         892      892              
  Lines       24867    24865       -2     
  Branches     2141     2141              
==========================================
+ Hits        16772    16774       +2     
+ Misses       7091     7087       -4     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.81% <50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 62.82% <0%> (+0.65%) ⬆️
...-4/react-core/src/components/Select/SelectMenu.tsx 82.25% <100%> (+0.59%) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.8% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bf30c...95e9f97. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 12, 2019

PatternFly-React preview: https://patternfly-react-pr-3298.surge.sh

Copy link
Contributor

kmcfaul left a comment

lgtm!

Copy link
Contributor

redallen left a comment

Good job! 🎖

@redallen redallen merged commit 913daeb into patternfly:master Nov 14, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 14, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.18
  • @patternfly/react-core@3.120.10
  • @patternfly/react-docs@4.16.23
  • @patternfly/react-inline-edit-extension@2.12.24
  • demo-app-ts@3.9.13
  • @patternfly/react-table@2.24.24
  • @patternfly/react-topology@2.11.10
  • @patternfly/react-virtualized-extension@1.3.23

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.