Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DonutChart): Put back secondary title when showing percentage #3299

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@adamruzicka
Copy link
Contributor

adamruzicka commented Nov 12, 2019

When using a percentage-type donut chart, there used to be primary title (the percentage) and secondary title, which indicated what the percentage actually means. This secondary title is not being shown anymore. I believe it was accidentally droped in #2375

What: Add back the secondary title for percentage-type donut charts.

Issue #3323

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 12, 2019

PatternFly-React preview: https://patternfly-react-pr-3299.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #3299 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files         892      892              
  Lines       24867    24868       +1     
  Branches     2141     2141              
==========================================
  Hits        16772    16772              
- Misses       7091     7092       +1     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <0%> (-0.01%) ⬇️
#patternfly4 64.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...atternfly-react/src/components/Chart/DonutChart.js 33.33% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c1bbc...4ef0d5a. Read the comment docs.

@tlabaj
tlabaj approved these changes Nov 19, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 592ef2d into patternfly:master Nov 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.