Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly import formatTime to DateTimePicker #3303

Conversation

@mzazrivec
Copy link
Contributor

mzazrivec commented Nov 13, 2019

What: missing import in DateTimePicker: #3302

Additional issues:

Fixes #3302
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 13, 2019

PatternFly-React preview: https://patternfly-react-pr-3303.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #3303 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   67.44%   67.43%   -0.01%     
==========================================
  Files         892      892              
  Lines       24867    24871       +4     
  Branches     2141     2141              
==========================================
+ Hits        16772    16773       +1     
- Misses       7091     7094       +3     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (-0.02%) ⬇️
#patternfly4 64.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ct/src/components/DateTimePicker/DateTimePicker.js 53.42% <ø> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c1bbc...ce6f566. Read the comment docs.

@martinpovolny

This comment has been minimized.

Copy link
Contributor

martinpovolny commented Nov 15, 2019

@jeff-phillips-18 : can you take a look?

@jeff-phillips-18 jeff-phillips-18 merged commit 4b5b538 into patternfly:master Nov 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@mzazrivec mzazrivec deleted the mzazrivec:import_format_time_to_datetimepicker branch Nov 15, 2019
@martinpovolny

This comment has been minimized.

Copy link
Contributor

martinpovolny commented Nov 15, 2019

Thank you!

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 15, 2019

Your changes have been released in:

  • patternfly-react-extensions@3.0.4
  • patternfly-react@2.39.8
  • @patternfly/react-console@2.0.4
  • @patternfly/react-catalog-view-extension@1.1.19
  • @patternfly/react-docs@4.16.24

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.