Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): Display pre-selected input #3305

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@SpyTec
Copy link
Contributor

SpyTec commented Nov 14, 2019

What: Closes #3304

Defaults typeaheadInputValue to null and sets it accordingly when clearing selections as well

Additional issues:

@SpyTec SpyTec force-pushed the SpyTec:fix/pre-select-typeahead branch from 9b49bcf to e0d4e85 Nov 14, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 14, 2019

PatternFly-React preview: https://patternfly-react-pr-3305.surge.sh

@tlabaj tlabaj requested a review from kmcfaul Nov 18, 2019
@tlabaj tlabaj requested a review from jessiehuff Nov 18, 2019
@SpyTec SpyTec force-pushed the SpyTec:fix/pre-select-typeahead branch from e0d4e85 to d3591a7 Nov 19, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 19, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2415a94). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3305   +/-   ##
=========================================
  Coverage          ?   67.45%           
=========================================
  Files             ?      892           
  Lines             ?    24874           
  Branches          ?     2141           
=========================================
  Hits              ?    16778           
  Misses            ?     7092           
  Partials          ?     1004
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.79% <100%> (?)
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 63.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415a94...7836046. Read the comment docs.

Copy link
Contributor

dlabaj left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

Looks like you need to update your jest test

@SpyTec SpyTec dismissed stale reviews from kmcfaul and dlabaj via 7836046 Nov 20, 2019
@SpyTec

This comment has been minimized.

Copy link
Contributor Author

SpyTec commented Nov 20, 2019

Thanks, updated the tests

@dlabaj
dlabaj approved these changes Nov 20, 2019
@tlabaj
tlabaj approved these changes Nov 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit f04fe92 into patternfly:master Nov 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.29
  • @patternfly/react-core@3.122.1
  • @patternfly/react-docs@4.16.35
  • @patternfly/react-inline-edit-extension@2.13.2
  • demo-app-ts@3.11.1
  • @patternfly/react-table@2.24.34
  • @patternfly/react-topology@2.11.20
  • @patternfly/react-virtualized-extension@1.3.33

Thanks for your contribution! 🎉

@SpyTec SpyTec deleted the SpyTec:fix/pre-select-typeahead branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.