Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accordion): Add a prop to allow the box shadow to be removed #3309

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Nov 18, 2019

What: Closes #3195

Additional issues:

@tlabaj tlabaj requested review from jessiehuff, mcoker and kmcfaul Nov 18, 2019
@tlabaj tlabaj changed the title feat(Accordion): Add a prop to allow th box shadow to be removed feat(Accordion): Add a prop to allow the box shadow to be removed Nov 18, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #3309 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files         892      892              
  Lines       24869    24871       +2     
  Branches     2141     2143       +2     
==========================================
  Hits        16774    16774              
  Misses       7090     7090              
- Partials     1005     1007       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.79% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
.../react-core/src/components/Accordion/Accordion.tsx 82.35% <0%> (-10.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a11090...23c141d. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 18, 2019

PatternFly-React preview: https://patternfly-react-pr-3309.surge.sh

Copy link
Contributor

jenny-s51 left a comment

Looks good and works as expected 👍

@mcoker
mcoker approved these changes Nov 19, 2019
Copy link
Contributor

mcoker left a comment

LGTM! 🏆

@dlabaj
dlabaj approved these changes Nov 20, 2019
@dlabaj dlabaj merged commit 02145a2 into patternfly:master Nov 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.28
  • @patternfly/react-core@3.122.0
  • @patternfly/react-docs@4.16.34
  • @patternfly/react-inline-edit-extension@2.13.1
  • demo-app-ts@3.11.0
  • @patternfly/react-integration@3.11.0
  • @patternfly/react-table@2.24.33
  • @patternfly/react-topology@2.11.19
  • @patternfly/react-virtualized-extension@1.3.32

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.