Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topology): Set topology container to take full height of the view #3314

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Nov 18, 2019

Closes #3312

@jeff-phillips-18 jeff-phillips-18 requested review from tlabaj and redallen Nov 18, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 18, 2019

PatternFly-React preview: https://patternfly-react-pr-3314.surge.sh

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch from b24b9d7 to 79b014f Nov 18, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #3314 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   67.44%   67.44%   +<.01%     
==========================================
  Files         892      892              
  Lines       24873    24874       +1     
  Branches     2141     2141              
==========================================
+ Hits        16775    16776       +1     
  Misses       7093     7093              
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.78% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...yles/src/css/components/Topology/topology-view.css 100% <ø> (ø) ⬆️
...ology/src/components/TopologyView/TopologyView.tsx 94.73% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8469e10...79b014f. Read the comment docs.

@tlabaj
tlabaj approved these changes Nov 18, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 2b15cc0 into patternfly:master Nov 18, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.