Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayName to exports wrapped in higher-order components #3318

Closed
wants to merge 2 commits into from

Conversation

@mturley
Copy link
Collaborator

mturley commented Nov 19, 2019

What: Fixes #3317

@mturley mturley requested a review from redallen Nov 19, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 19, 2019

PatternFly-React preview: https://patternfly-react-pr-3318.surge.sh

@mturley

This comment has been minimized.

Copy link
Collaborator Author

mturley commented Nov 19, 2019

For anyone who finds this: the test failures here (wrapper.find() suddenly finding two of a component instead of one, in several places) indicate that this quick-fix for snapshots will break lots of other tests. We're currently discussing other options.

@mturley

This comment has been minimized.

Copy link
Collaborator Author

mturley commented Nov 26, 2019

Closing this since we'll need to work around the other HOC-related enzyme issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.