Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flex): typo in align and justify modifiers #3328

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Nov 20, 2019

What: Closes #3327

There were typos in the modifiers:

  • justify-content-flex-space-between => justify-content-space-between
  • align-self-flex-stretch => align-self-stretch
  • align-self-flex-baseline => align-self-baseline
  • align-self-flex-center => align-self-center

//cc @tlabaj @sahil143

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #3328 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3328      +/-   ##
=========================================
+ Coverage   67.37%   67.5%   +0.13%     
=========================================
  Files         893     894       +1     
  Lines       24957   25044      +87     
  Branches     2157    2155       -2     
=========================================
+ Hits        16815   16907      +92     
+ Misses       7136    7131       -5     
  Partials     1006    1006
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.96% <100%> (+0.3%) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/layouts/Flex/FlexUtils.tsx 100% <100%> (ø)
...nfly-4/react-core/src/components/Select/Select.tsx 62.82% <0%> (-1.05%) ⬇️
.../react-core/src/components/Accordion/Accordion.tsx 93.33% <0%> (+10.98%) ⬆️
.../patternfly-4/react-core/src/layouts/Flex/Flex.tsx 100% <0%> (+18.18%) ⬆️
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 72.72% <0%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe604f3...11a8b73. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

PatternFly-React preview: https://patternfly-react-pr-3328.surge.sh

@tlabaj tlabaj requested a review from rebeccaalpert Nov 20, 2019
@tlabaj
tlabaj approved these changes Nov 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 89f8bae into patternfly:master Nov 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.30
  • @patternfly/react-core@3.122.2
  • @patternfly/react-docs@4.16.36
  • @patternfly/react-inline-edit-extension@2.13.3
  • demo-app-ts@3.11.2
  • @patternfly/react-table@2.24.35
  • @patternfly/react-topology@2.11.21
  • @patternfly/react-virtualized-extension@1.3.34

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.