Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CatalogTile): Removed unneeded selector #3331

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Nov 20, 2019

Removed unneeded class that addresses a separate component for some reason.

Copy link
Contributor

jcaianirh left a comment

lgtm

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

PatternFly-React preview: https://patternfly-react-pr-3331.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@89f8bae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3331   +/-   ##
=========================================
  Coverage          ?   67.44%           
=========================================
  Files             ?      892           
  Lines             ?    24874           
  Branches          ?     2141           
=========================================
  Hits              ?    16776           
  Misses            ?     7093           
  Partials          ?     1005
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.78% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f8bae...b137ad7. Read the comment docs.

@rebeccaalpert rebeccaalpert merged commit 5892d50 into patternfly:master Nov 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:catalogtileedits branch Nov 20, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.31
  • @patternfly/react-docs@4.16.37

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.