Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog-view-extension): remove unused packages #3332

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@jcaianirh
Copy link
Contributor

jcaianirh commented Nov 20, 2019

remove unused packages from package.json

Additional issues:

remove unused packages from packages.json
@jcaianirh jcaianirh requested a review from rebeccaalpert Nov 20, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #3332 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   67.51%   67.37%   -0.14%     
==========================================
  Files         894      893       -1     
  Lines       25046    24957      -89     
  Branches     2157     2157              
==========================================
- Hits        16909    16815      -94     
- Misses       7130     7136       +6     
+ Partials     1007     1006       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.66% <ø> (-0.31%) ⬇️
Impacted Files Coverage Δ
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 45.45% <0%> (-27.28%) ⬇️
.../patternfly-4/react-core/src/layouts/Flex/Flex.tsx 81.81% <0%> (-18.19%) ⬇️
...ernfly-4/react-core/src/layouts/Flex/FlexUtils.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5892d50...3e59d54. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

PatternFly-React preview: https://patternfly-react-pr-3332.surge.sh

@tlabaj
tlabaj approved these changes Nov 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@jcaianirh jcaianirh merged commit a3fcfcc into patternfly:master Nov 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 20, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.32
  • @patternfly/react-docs@4.16.38

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.