Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF3: add spacing between VncAction buttons in react-console #3345

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Nov 22, 2019

Addresses #3105

@nicolethoen nicolethoen added the PF3 label Nov 22, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 22, 2019

PatternFly-React preview: https://patternfly-react-pr-3345.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #3345 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   67.52%   67.37%   -0.16%     
==========================================
  Files         896      893       -3     
  Lines       25112    24957     -155     
  Branches     2173     2157      -16     
==========================================
- Hits        16958    16815     -143     
+ Misses       7141     7136       -5     
+ Partials     1013     1006       -7
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.66% <ø> (-0.36%) ⬇️
Impacted Files Coverage Δ
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 45.45% <0%> (-27.28%) ⬇️
.../patternfly-4/react-core/src/layouts/Flex/Flex.tsx 81.81% <0%> (-18.19%) ⬇️
...mental/components/DataToolbar/DataToolbarGroup.tsx 93.75% <0%> (-6.25%) ⬇️
...nents/DataToolbar/DataToolbarExpandableContent.tsx 95.23% <0%> (-1.06%) ⬇️
...nfly-4/react-core/src/components/Select/Select.tsx 63.87% <0%> (-0.42%) ⬇️
...nfly-4/react-core/src/components/Button/Button.tsx 88.23% <0%> (-0.23%) ⬇️
...nfly-4/react-core/src/components/Dropdown/index.ts 100% <0%> (ø) ⬆️
...mental/components/DataToolbar/DataToolbarUtils.tsx 100% <0%> (ø) ⬆️
...3/patternfly-react/src/components/Button/Button.js 100% <0%> (ø) ⬆️
...ntal/components/DataToolbar/DataToolbarContent.tsx 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04575a6...3b4a6f2. Read the comment docs.

@nicolethoen nicolethoen force-pushed the nicolethoen:pf3_console_button_spacing branch from 728bb29 to 3b4a6f2 Nov 22, 2019
@KKoukiou

This comment has been minimized.

Copy link
Contributor

KKoukiou commented Dec 9, 2019

I tried it on cockpit - this change works, thanks.

@nicolethoen nicolethoen changed the title [WIP] PF3: add spacing between VncAction buttons in react-console PF3: add spacing between VncAction buttons in react-console Dec 9, 2019
@nicolethoen nicolethoen requested a review from tlabaj Dec 9, 2019
@tlabaj
tlabaj approved these changes Dec 9, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit fdb27c8 into patternfly:master Dec 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 9, 2019

Your changes have been released in:

  • @patternfly/react-console@2.0.6

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.