Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various table state demos #3352

Merged
merged 2 commits into from Dec 4, 2019
Merged

Add various table state demos #3352

merged 2 commits into from Dec 4, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Nov 25, 2019

Addresses #3330

@nicolethoen nicolethoen requested review from mcarrano and dlabrecq Nov 25, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 25, 2019

PatternFly-React preview: https://patternfly-react-pr-3352.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #3352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3352   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         896      896           
  Lines       25112    25112           
  Branches     2173     2173           
=======================================
  Hits        16958    16958           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bd323...f613acf. Read the comment docs.

Copy link
Member

mcarrano left a comment

These look great @nicolethoen . I'm just wondering about the naming of this demo. Would "Table empty states" be more descriptive? @rachael-phillips what do you think?

Copy link
Member

dlabrecq left a comment

Looks good. Thanks for adding these examples

@nicolethoen nicolethoen dismissed stale reviews from dlabrecq and mcarrano via f613acf Dec 2, 2019
@nicolethoen nicolethoen force-pushed the nicolethoen:table_demos branch from 071d493 to f613acf Dec 2, 2019
@nicolethoen nicolethoen force-pushed the nicolethoen:table_demos branch from f613acf to bea59bd Dec 3, 2019
@nicolethoen nicolethoen force-pushed the nicolethoen:table_demos branch from bea59bd to 381d513 Dec 3, 2019
@tlabaj
tlabaj approved these changes Dec 4, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Dec 4, 2019
@dlabaj dlabaj merged commit 6b35f6b into patternfly:master Dec 4, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 4, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.43
  • @patternfly/react-core@3.125.1
  • @patternfly/react-docs@4.16.50
  • @patternfly/react-inline-edit-extension@2.14.1
  • demo-app-ts@3.13.5
  • @patternfly/react-table@2.24.45
  • @patternfly/react-topology@2.11.31
  • @patternfly/react-virtualized-extension@1.3.44

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.