Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): make integration tests pass #3359

Merged
merged 1 commit into from Dec 2, 2019
Merged

Conversation

@boaz0
Copy link
Member

boaz0 commented Nov 27, 2019

What:

closes #3334

  • Add more options to show the "1 more" chip
  • Update CSS selector to click the clearn button
  • Workaround to Cypress unable to click the label option
- Add more options to show the "1 more" chip
- Update CSS selector to click the clearn button
- Workaround to Cypress unable to click the label option

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 27, 2019

PatternFly-React preview: https://patternfly-react-pr-3359.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #3359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3359   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         896      896           
  Lines       25112    25112           
  Branches     2173     2173           
=======================================
  Hits        16958    16958           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b110a3f...4b6bded. Read the comment docs.

@tlabaj
tlabaj approved these changes Dec 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 9ce7eff into patternfly:master Dec 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Dec 2, 2019

Thank you all! 🙇

@boaz0 boaz0 deleted the boaz0:closes_3334 branch Dec 2, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 2, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.40
  • @patternfly/react-core@3.124.3
  • @patternfly/react-docs@4.16.46
  • @patternfly/react-inline-edit-extension@2.13.11
  • demo-app-ts@3.13.3
  • @patternfly/react-integration@3.13.1
  • @patternfly/react-table@2.24.43
  • @patternfly/react-topology@2.11.29
  • @patternfly/react-virtualized-extension@1.3.42

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.