Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): rename visible/hiddenOn2Xl to visible/hiddenOn_2xl #3365

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Dec 2, 2019

What: Closes #3355

Visibility doesn't have hiddenOn2Xl and visibleOn2Xl and that's why they are set to undefined and are not shown in the class prop.
Nevertheless, these two modifiers exist according to the pf4 core documentations.

The problem is that the way react-style parses a modifier name is if it has a number, it will add _ before it. Thus, hidden-on-2xl will be hiddenOn_2xl and not hiddenOn2Xl.

This patch fixes this and adds a test to verify it works.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 2, 2019

PatternFly-React preview: https://patternfly-react-pr-3365.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #3365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3365   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files         897      897           
  Lines       25120    25120           
  Branches     2173     2173           
=======================================
  Hits        16966    16966           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rc/components/Table/utils/decorators/classNames.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5016b5...835609e. Read the comment docs.

@tlabaj
tlabaj approved these changes Dec 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj added the bug 🐛 label Dec 5, 2019
@kmcfaul
kmcfaul approved these changes Dec 6, 2019
@tlabaj tlabaj merged commit 45049a2 into patternfly:master Dec 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 6, 2019

Your changes have been released in:

  • @patternfly/react-docs@4.16.57
  • @patternfly/react-inline-edit-extension@2.14.7
  • @patternfly/react-table@2.24.51

Thanks for your contribution! 🎉

@boaz0 boaz0 deleted the boaz0:closes_3355 branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.