Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tippy.js dependency #3370

Merged
merged 2 commits into from Dec 5, 2019
Merged

Update tippy.js dependency #3370

merged 2 commits into from Dec 5, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Dec 3, 2019

Addresses: #3252

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 3, 2019

PatternFly-React preview: https://patternfly-react-pr-3370.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #3370 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   67.53%   67.52%   -0.02%     
==========================================
  Files         897      897              
  Lines       25120    25124       +4     
  Branches     2173     2173              
==========================================
  Hits        16966    16966              
- Misses       7141     7145       +4     
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.02% <33.33%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Popover/Popover.tsx 61.01% <ø> (ø) ⬆️
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84.74% <ø> (ø) ⬆️
.../react-core/src/helpers/PopoverBase/PopoverBase.js 65.95% <33.33%> (-1.83%) ⬇️
...patternfly-react/src/components/Tooltip/Tooltip.js 93.1% <0%> (-1.15%) ⬇️
...patternfly-react/src/components/Popover/Popover.js 31.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0050615...ec54cd0. Read the comment docs.

@nicolethoen nicolethoen requested review from rebeccaalpert, redallen and tlabaj Dec 3, 2019
@@ -95,7 +95,7 @@ export interface PopoverProps {
/** z-index of the popover */
zIndex?: number;
/** additional Props to pass through to tippy.js */
tippyProps?: TippyProps;
tippyProps?: object;

This comment has been minimized.

Copy link
@redallen

redallen Dec 3, 2019

Contributor

Are Tippy's types no longer working? Avoiding object would be nice for consumers.

This comment has been minimized.

Copy link
@nicolethoen

nicolethoen Dec 3, 2019

Author Contributor

there are like 43 required TippyProps. So in the tests, for example, we tried only passing two tippy props, we get a type error.

This comment has been minimized.

Copy link
@redallen

redallen Dec 3, 2019

Contributor

Does Partial<TippyProps> work?

@nicolethoen nicolethoen force-pushed the nicolethoen:popover_bug branch from 7317963 to ec54cd0 Dec 3, 2019
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Dec 3, 2019

Thanks Nicole!

@tlabaj tlabaj requested a review from jschuler Dec 5, 2019
@tlabaj tlabaj added the chore 🏠 label Dec 5, 2019
@jschuler jschuler merged commit 68c9736 into patternfly:master Dec 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.