Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(EmptyStateIcon): mark deprecated props #3375

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Dec 3, 2019

What: Closes #3335

@kmcfaul kmcfaul requested a review from tlabaj Dec 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 3, 2019

PatternFly-React preview: https://patternfly-react-pr-3375.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #3375 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
- Coverage   67.53%   67.52%   -0.02%     
==========================================
  Files         897      896       -1     
  Lines       25120    25112       -8     
  Branches     2173     2173              
==========================================
- Hits        16966    16958       -8     
  Misses       7141     7141              
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.01% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
...-core/src/components/EmptyState/EmptyStateIcon.tsx 94.11% <ø> (ø) ⬆️
.../react-core/src/components/TextInput/TextInput.tsx 95.12% <0%> (-0.44%) ⬇️
...kages/patternfly-4/react-core/src/helpers/index.ts 100% <0%> (ø) ⬆️
...tternfly-4/react-core/src/helpers/withInnerRef.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d6fa0...a450b8c. Read the comment docs.

@tlabaj
tlabaj approved these changes Dec 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Dec 5, 2019
@tlabaj tlabaj merged commit 7ad72d3 into patternfly:master Dec 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 5, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.48
  • @patternfly/react-core@3.126.4
  • @patternfly/react-docs@4.16.55
  • @patternfly/react-inline-edit-extension@2.14.6
  • demo-app-ts@3.14.4
  • @patternfly/react-table@2.24.50
  • @patternfly/react-topology@2.11.36
  • @patternfly/react-virtualized-extension@1.3.49

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.