Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover - make text selectable #3376

Merged
merged 2 commits into from Dec 5, 2019
Merged

Popover - make text selectable #3376

merged 2 commits into from Dec 5, 2019

Conversation

@jschuler
Copy link
Collaborator

jschuler commented Dec 4, 2019

What: Closes #3368
Also fixes that after closing the popover, the Button that opened it should be re-focused

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 4, 2019

PatternFly-React preview: https://patternfly-react-pr-3376.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #3376 into master will decrease coverage by 0.03%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3376      +/-   ##
=========================================
- Coverage   67.53%   67.5%   -0.04%     
=========================================
  Files         897     897              
  Lines       25120   25133      +13     
  Branches     2173    2176       +3     
=========================================
+ Hits        16966   16967       +1     
- Misses       7141    7152      +11     
- Partials     1013    1014       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.98% <40%> (-0.07%) ⬇️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Popover/Popover.tsx 58.4% <40%> (-2.62%) ⬇️
...patternfly-react/src/components/Popover/Popover.js 30.06% <0%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb91469...b05ec8f. Read the comment docs.

@tlabaj tlabaj added the bug 🐛 label Dec 4, 2019
@tlabaj
tlabaj approved these changes Dec 4, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Dec 5, 2019
@dlabaj dlabaj merged commit 4c667ad into patternfly:master Dec 5, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.