Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): added optional offset prop #3383

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@evwilkin
Copy link
Contributor

evwilkin commented Dec 6, 2019

What: Closes #1567

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 6, 2019

PatternFly-React preview: https://patternfly-react-pr-3383.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #3383 into master will decrease coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3383      +/-   ##
==========================================
- Coverage   67.49%   67.47%   -0.02%     
==========================================
  Files         897      897              
  Lines       25158    25165       +7     
  Branches     2181     2183       +2     
==========================================
  Hits        16980    16980              
- Misses       7162     7167       +5     
- Partials     1016     1018       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.91% <40%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...eact-core/src/components/Pagination/Pagination.tsx 77.61% <40%> (-3.64%) ⬇️
...nfly-react/src/components/Pagination/Pagination.js 26.21% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4826ce9...8b0bb8c. Read the comment docs.

@evwilkin evwilkin requested review from seanforyou23 and dlabrecq Dec 6, 2019
Copy link
Member

dlabrecq left a comment

Looks good. Thanks for adding this

@tlabaj
tlabaj approved these changes Dec 11, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 1dd38a1 into patternfly:master Dec 11, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.