Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(PageLayout): set breadcrumb, nav and title texts to sentence case #3387

Merged
merged 2 commits into from Dec 16, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Dec 8, 2019

What: Closes #3353

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 8, 2019

PatternFly-React preview: https://patternfly-react-pr-3387.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #3387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3387   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         897      897           
  Lines       25158    25158           
  Branches     2181     2181           
=======================================
  Hits        16980    16980           
  Misses       7162     7162           
  Partials     1016     1016
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a6eb5...f97e683. Read the comment docs.

Copy link
Contributor

tlabaj left a comment

The Breadcrumb component examples also needs to be updated as part of this PR.

Titani
@tlabaj tlabaj dismissed their stale review Dec 16, 2019

Made updates

@tlabaj tlabaj requested review from dlabaj and nicolethoen Dec 16, 2019
@dlabaj
dlabaj approved these changes Dec 16, 2019
Copy link
Contributor

jessiehuff left a comment

LGTM :)

@dlabaj dlabaj merged commit f9232ef into patternfly:master Dec 16, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 16, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.55
  • @patternfly/react-core@3.128.1
  • @patternfly/react-docs@4.16.66
  • @patternfly/react-inline-edit-extension@2.14.15
  • demo-app-ts@3.15.1
  • @patternfly/react-table@2.24.59
  • @patternfly/react-topology@2.11.43
  • @patternfly/react-virtualized-extension@1.3.56

Thanks for your contribution! 🎉

@boaz0 boaz0 deleted the boaz0:closes_3353 branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.