Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): Update component to use input rather than PF Checkbox #3391

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Dec 10, 2019

#3325

What: Closes #

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 10, 2019

PatternFly-React preview: https://patternfly-react-pr-3391.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #3391 into master will increase coverage by 2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3391      +/-   ##
==========================================
+ Coverage   67.49%   69.49%      +2%     
==========================================
  Files         897      465     -432     
  Lines       25158    13596   -11562     
  Branches     2181        0    -2181     
==========================================
- Hits        16980     9449    -7531     
+ Misses       7162     4147    -3015     
+ Partials     1016        0    -1016
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 ?
Impacted Files Coverage Δ
...ponents/ApplicationLauncher/ApplicationLauncher.js 71.42% <0%> (-19.24%) ⬇️
...fly-3/patternfly-react/src/components/Nav/index.js 62.5% <0%> (-15%) ⬇️
...atternfly-react/src/components/Breadcrumb/index.js 60% <0%> (-12.23%) ⬇️
...patternfly-react/src/components/Toolbar/Toolbar.js 74.46% <0%> (-8.59%) ⬇️
...ly-3/patternfly-react/src/components/Tabs/index.js 64.7% <0%> (-6.73%) ⬇️
...tternfly-react/src/components/Wizard/WizardBody.js 71.42% <0%> (-6.7%) ⬇️
...ernfly-react/src/components/Wizard/WizardFooter.js 71.42% <0%> (-6%) ⬇️
.../patternfly-react/src/components/Dropdown/index.js 87.5% <0%> (-3.27%) ⬇️
...-3/patternfly-react/src/components/Button/index.js 85.71% <0%> (-2.53%) ⬇️
...y-3/patternfly-react/src/components/Badge/index.js 60% <0%> (-2.5%) ⬇️
... and 475 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3cd3d...618e22f. Read the comment docs.

Copy link
Contributor

nicolethoen left a comment

LGTM

@mcoker
mcoker approved these changes Dec 11, 2019
Copy link
Contributor

mcoker left a comment

👍 thanks!

@kmcfaul kmcfaul merged commit 89561d5 into patternfly:master Dec 12, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 12, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.51
  • @patternfly/react-core@3.127.1
  • @patternfly/react-docs@4.16.60
  • @patternfly/react-inline-edit-extension@2.14.10
  • demo-app-ts@3.14.7
  • @patternfly/react-table@2.24.54
  • @patternfly/react-topology@2.11.39
  • @patternfly/react-virtualized-extension@1.3.52

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.