Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): Fix the ActionColumn to allow a link in the actions menu #3402

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Dec 12, 2019

Closes #3392

@tlabaj tlabaj added the bug 🐛 label Dec 12, 2019
@tlabaj tlabaj requested review from seanforyou23 and dlabaj Dec 12, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 12, 2019

PatternFly-React preview: https://patternfly-react-pr-3402.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #3402 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3402      +/-   ##
==========================================
- Coverage   67.46%   67.46%   -0.01%     
==========================================
  Files         897      897              
  Lines       25164    25165       +1     
  Branches     2183     2184       +1     
==========================================
  Hits        16978    16978              
- Misses       7168     7169       +1     
  Partials     1018     1018
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.89% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...react-table/src/components/Table/ActionsColumn.tsx 76% <0%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9909f88...0c728ba. Read the comment docs.

// tslint:disable-next-line:no-unused-expression
onClick && onClick(event as React.MouseEvent, extraData && extraData.rowIndex, rowData, extraData);
// Only prevent default if onClick is provided. This allows href support.
if (onclick) {

This comment has been minimized.

Copy link
@jschuler

jschuler Dec 13, 2019

Collaborator

should the c be capitalized?

Suggested change
if (onclick) {
if (onClick) {
Copy link
Member

seanforyou23 left a comment

👍

Titani
@tlabaj tlabaj dismissed stale reviews from seanforyou23 and dlabaj via 0c728ba Dec 13, 2019
Copy link
Member

seanforyou23 left a comment

👍

@jschuler jschuler merged commit e609cdd into patternfly:master Dec 13, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 13, 2019

Your changes have been released in:

  • @patternfly/react-docs@4.16.64
  • @patternfly/react-inline-edit-extension@2.14.13
  • @patternfly/react-table@2.24.57

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.