Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Katacoda tutorial links #3408

Merged
merged 1 commit into from Dec 17, 2019
Merged

Broken Katacoda tutorial links #3408

merged 1 commit into from Dec 17, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Dec 16, 2019

The Katacoda chart tutorials have moved to a new directory. Thus, the links in the chart examples are broken.

This:
https://katacoda.com/patternfly/courses/charts/area-chart

Should be:
https://katacoda.com/patternfly/courses/react-charts/area-chart
fixes #3407

@dlabrecq dlabrecq changed the title Broken Katacoda tutorials links Broken Katacoda tutorial links Dec 16, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 16, 2019

PatternFly-React preview: https://patternfly-react-pr-3408.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #3408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         897      897           
  Lines       25173    25173           
  Branches     2190     2190           
=======================================
  Hits        16979    16979           
  Misses       7170     7170           
  Partials     1024     1024
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3249fe0...2e60708. Read the comment docs.

@christiemolloy

This comment has been minimized.

Copy link
Member

christiemolloy commented Dec 16, 2019

Alternatively, we could link to the training modules on the website which will be added in this release: patternfly/patternfly-org#1586

https://www.patternfly.org/v4/documentation/core/overview/training

@dlabrecq dlabrecq requested review from redallen and ddonahue007 Dec 16, 2019
Copy link
Contributor

redallen left a comment

We're adding a whole Katacoda section to the site with the next release thanks to @christiemolloy ! Maybe we can include a charts section under there in the future.

@tlabaj
tlabaj approved these changes Dec 17, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit e6e72cd into patternfly:master Dec 17, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 17, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.2.8
  • @patternfly/react-docs@4.16.70

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:3407-katacoda branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.