Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF3] Update CustomModalDialog to match changes to original react-bootstrap ModalDialog #3409

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@mturley
Copy link
Collaborator

mturley commented Dec 16, 2019

What: Closes #3364

As detailed in my comment here, since upgrading react-bootstrap in #3249 we have had a warning appear when rendering a <Modal>. This is happening because we created CustomModalDialog based on the react-bootstrap ModalDialog in order to introduce a custom prop, and react-bootstrap has since made a change requiring updates to their original ModalDialog.

Our CustomModalDialog was introduced in 9b0f3d9 (Nov 13, 2017). Looking at the history of react-bootstrap's original ModalDialog, we can see that the only real (non-code-style) change they made since we copied it was this one which introduces the onMouseDownDialog prop. This PR simply replicates that change in our CustomModalDialog.

Additional issues: This should also unblock the resolution of ManageIQ/manageiq-v2v#1037

cc @laviro @martinpovolny @himdel

@mturley mturley added the PF3 label Dec 16, 2019
@mturley mturley requested a review from laviro Dec 16, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 16, 2019

PatternFly-React preview: https://patternfly-react-pr-3409.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #3409 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3409      +/-   ##
==========================================
+ Coverage   67.12%   67.45%   +0.32%     
==========================================
  Files         903      897       -6     
  Lines       25445    25170     -275     
  Branches     2243     2190      -53     
==========================================
- Hits        17080    16978     -102     
+ Misses       7334     7168     -166     
+ Partials     1031     1024       -7
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <100%> (ø) ⬆️
#patternfly4 64.86% <ø> (+0.6%) ⬆️
Impacted Files Coverage Δ
...ponents/Modal/InnerComponents/CustomModalDialog.js 66.07% <100%> (+1.66%) ⬆️
...tternfly-4/react-core/src/components/List/List.tsx 83.33% <0%> (-4.67%) ⬇️
...eact-core/src/components/Dropdown/DropdownItem.tsx 68.42% <0%> (-3.01%) ⬇️
...eact-core/src/components/Dropdown/DropdownMenu.tsx 51.85% <0%> (-2.39%) ⬇️
...ApplicationLauncher/ApplicationLauncherContent.tsx
...ts/ApplicationLauncher/ApplicationLauncherText.tsx
...ts/ApplicationLauncher/ApplicationLauncherItem.tsx
...s/ApplicationLauncher/ApplicationLauncherGroup.tsx
...ts/ApplicationLauncher/ApplicationLauncherIcon.tsx
...plicationLauncher/ApplicationLauncherSeparator.tsx
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc8e80...a054f74. Read the comment docs.

@tlabaj
tlabaj approved these changes Dec 16, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Dec 16, 2019
@dlabaj dlabaj merged commit d27586d into patternfly:master Dec 16, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 16, 2019

Your changes have been released in:

  • patternfly-react-extensions@3.0.6
  • patternfly-react@2.39.10
  • @patternfly/react-console@2.0.7

Thanks for your contribution! 🎉

@mturley mturley deleted the mturley:3364-custom-modal-dialog-bug branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.