Join GitHub today
fix(docs): documented CJS tree shaking solution for icons and react-core #3410
@@ Coverage Diff @@ ## master #3410 +/- ## ========================================== + Coverage 67.12% 67.44% +0.32% ========================================== Files 903 897 -6 Lines 25442 25173 -269 Branches 2243 2190 -53 ========================================== - Hits 17079 16979 -100 + Misses 7332 7170 -162 + Partials 1031 1024 -7
Your changes have been released in:
Thanks for your contribution!
@evwilkin : First on all I'd like to thank you for keeping working on this. I really appreciate that despite what I am going to write next.
So I have to say that this issue makes me wonder about Patternfly development processes.
You have an issue that is complex, hard to fix, hard to understand, hard to discuss.
You discuss it for weeks. Have ideas, some wrong, some right, obviously it's not a simple thing.
The issue was already once prematurely closed and reopened.
Then you make a PR and merge it within 1 hour. Merge it within one hour since it was opened w/o giving the people who where previously discussing the issue a chance to check it/test it/review it.
Well and no. It did not resolve the issue.
Wow. Just wow.