Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): ensure getElement does not return null #4544

Merged
merged 3 commits into from Jul 28, 2020
Merged

fix(Modal): ensure getElement does not return null #4544

merged 3 commits into from Jul 28, 2020

Conversation

nicolethoen
Copy link
Contributor

Closes #4093
@KKoukiou could you test this change and be extra sure this addresses your specific issue?

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 14, 2020 •
edited

PF4 preview: https://patternfly-react-pr-4544.surge.sh
A11y report: https://patternfly-react-pr-4544-coverage.surge.sh

@KKoukiou
Copy link
Collaborator

KKoukiou commented Jul 15, 2020 •
edited

Closes #4093
@KKoukiou could you test this change and be extra sure this addresses your specific issue?

Ack I will take a look and respond tomorrow. I see you just force pushed so I will verify the current commit. Next time feel free to add me as a reviewer.

dlabrecq
dlabrecq approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Followed the conversation on the patternfly-react channel

@nicolethoen
Copy link
Contributor Author

@KKoukiou any word on this?

@KKoukiou
Copy link
Collaborator

@nicolethoen works as expected. Thanks.

tlabaj
tlabaj approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 358b0e2 into patternfly:master Jul 28, 2020
@nicolethoen nicolethoen deleted the modal_appendTo branch February 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabrecq dlabrecq dlabrecq approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal(PF4): when not specifying appendTo property the component will crash
5 participants
@nicolethoen @patternfly-build @KKoukiou @dlabrecq @tlabaj