feat(DataList): expose grid modifiers as properties #4969
Conversation
|
PF4 preview: https://patternfly-react-pr-4969.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #4969 +/- ##
=======================================
Coverage 52.15% 52.15%
=======================================
Files 530 530
Lines 9769 9770 +1
Branches 3597 3597
=======================================
+ Hits 5095 5096 +1
Misses 4013 4013
Partials 661 661
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| import { PickOptional } from '../../helpers/typeUtils'; | ||
|
|
||
| export enum DataListGridBreakpoint { | ||
| gridNone = 'grid-none', |
There was a problem hiding this comment.
I need to expose grid as well here
#4965 (comment)
| import { PickOptional } from '../../helpers/typeUtils'; | ||
|
|
||
| export enum DataListGridBreakpoint { |
There was a problem hiding this comment.
You don't have to export an enum (strings work just fine), but if you do, make sure to add it to the gridBreakPoint type in DataListProps.
KKoukiou
force-pushed
the
issue-4965
branch
3 times, most recently
from
bc7e7e5
to
25c100d
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Closes #4965