Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datalist): fix dragging in firefox #5505

Merged
merged 2 commits into from Mar 3, 2021
Merged

fix(datalist): fix dragging in firefox #5505

merged 2 commits into from Mar 3, 2021

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Mar 1, 2021

What: Closes #5455

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 1, 2021 •
edited

PF4 preview: https://patternfly-react-pr-5505.surge.sh
A11y report: https://patternfly-react-pr-5505-a11y.surge.sh

@tlabaj tlabaj requested a review from kmcfaul March 2, 2021 15:52
jessiehuff
jessiehuff approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works on Chrome, Firefox, and Safari for me. 🙂

@redallen redallen merged commit bfb6ec7 into patternfly:master Mar 3, 2021
@KKoukiou KKoukiou mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@jessiehuff jessiehuff jessiehuff approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees

@kmcfaul kmcfaul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draggable Datalist doesn't work in Firefox or Safari
5 participants
@redallen @patternfly-build @nicolethoen @jessiehuff @kmcfaul