Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Progress): NaN not returned when max and value are zero #6867

Merged
merged 2 commits into from Feb 7, 2022
Merged

fix(Progress): NaN not returned when max and value are zero #6867

merged 2 commits into from Feb 7, 2022

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #6733

Additional issues:
N/A

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 28, 2022 •
edited

Preview: https://patternfly-react-pr-6867.surge.sh

kmcfaul
kmcfaul approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 184e9f0 into patternfly:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitdallas gitdallas gitdallas approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@wise-king-sullyman wise-king-sullyman Awaiting requested review from wise-king-sullyman

Assignees

@kmcfaul kmcfaul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When value and max values are not defined for Progress a NaN% is returned for the measure
6 participants
@thatblindgeye @patternfly-build @gitdallas @nicolethoen @tlabaj @kmcfaul