From 11d13139774cfadf1e7bdb7beb6104a294750590 Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Tue, 18 Oct 2022 09:53:24 -0400 Subject: [PATCH 1/2] chore(Skeleton): update examples to typescript --- .../components/Skeleton/examples/Skeleton.md | 103 +----------------- .../Skeleton/examples/SkeletonBasic.tsx | 4 + .../examples/SkeletonPercentageHeight.tsx | 13 +++ .../examples/SkeletonPercentageWidth.tsx | 18 +++ .../Skeleton/examples/SkeletonShapes.tsx | 39 +++++++ .../Skeleton/examples/SkeletonText.tsx | 27 +++++ 6 files changed, 106 insertions(+), 98 deletions(-) create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonShapes.tsx create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonText.tsx diff --git a/packages/react-core/src/components/Skeleton/examples/Skeleton.md b/packages/react-core/src/components/Skeleton/examples/Skeleton.md index 3db117e243a..1987422559f 100644 --- a/packages/react-core/src/components/Skeleton/examples/Skeleton.md +++ b/packages/react-core/src/components/Skeleton/examples/Skeleton.md @@ -9,118 +9,25 @@ propComponents: ['Skeleton'] ### Default -```js -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - -; +```ts file="./SkeletonBasic.tsx" ``` ### Percentage widths -```js -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - - - -
- -
- -
- -
- -
- -
; +```ts file="./SkeletonPercentageWidth.tsx" ``` ### Percentage heights -```js -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - -
- - - - - - -
; +```ts file="./SkeletonPercentageHeight.tsx" ``` ### Text modifiers -```js -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - - - --pf-global--FontSize--4xl - -
- --pf-global--FontSize--3xl - -
- --pf-global--FontSize--2xl - -
- --pf-global--FontSize--xl - -
- --pf-global--FontSize--lg - -
- --pf-global--FontSize--md - -
- --pf-global--FontSize--sm - -
; +```ts file="./SkeletonText.tsx" ``` ### Shapes -```js -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - - - Small circle - -
- Medium circle - -
- Large circle - -
- Small square - -
- Medium square - -
- Large square - -
- Small rectangle -
- -
-
- Medium rectangle -
- -
-
- Large rectangle -
- -
-
; +```ts file="./SkeletonShapes.tsx" ``` diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx new file mode 100644 index 00000000000..846b42d0ef8 --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx @@ -0,0 +1,4 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonBasic: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx new file mode 100644 index 00000000000..6ca74b757fc --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx @@ -0,0 +1,13 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonPercentageHeight: React.FunctionComponent = () => ( +
+ + + + + + +
+); diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx new file mode 100644 index 00000000000..1e40d2c8d9a --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx @@ -0,0 +1,18 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonPercentageWidth: React.FunctionComponent = () => ( + + +
+ +
+ +
+ +
+ +
+ +
+); diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonShapes.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonShapes.tsx new file mode 100644 index 00000000000..e94153ce482 --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonShapes.tsx @@ -0,0 +1,39 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonShapes: React.FunctionComponent = () => ( + + Small circle + +
+ Medium circle + +
+ Large circle + +
+ Small square + +
+ Medium square + +
+ Large square + +
+ Small rectangle +
+ +
+
+ Medium rectangle +
+ +
+
+ Large rectangle +
+ +
+
+); diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonText.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonText.tsx new file mode 100644 index 00000000000..160b9dfc49f --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonText.tsx @@ -0,0 +1,27 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonText: React.FunctionComponent = () => ( + + --pf-global--FontSize--4xl + +
+ --pf-global--FontSize--3xl + +
+ --pf-global--FontSize--2xl + +
+ --pf-global--FontSize--xl + +
+ --pf-global--FontSize--lg + +
+ --pf-global--FontSize--md + +
+ --pf-global--FontSize--sm + +
+); From 35f307fd4b5e86b070205a3e1d50d03e67cd4058 Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Fri, 21 Oct 2022 11:13:48 -0400 Subject: [PATCH 2/2] update example name, update sreenreader text --- .../src/components/Skeleton/examples/Skeleton.md | 2 +- .../components/Skeleton/examples/SkeletonBasic.tsx | 4 ---- .../components/Skeleton/examples/SkeletonDefault.tsx | 4 ++++ .../Skeleton/examples/SkeletonPercentageHeight.tsx | 12 ++++++------ .../Skeleton/examples/SkeletonPercentageWidth.tsx | 10 +++++----- 5 files changed, 16 insertions(+), 16 deletions(-) delete mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx create mode 100644 packages/react-core/src/components/Skeleton/examples/SkeletonDefault.tsx diff --git a/packages/react-core/src/components/Skeleton/examples/Skeleton.md b/packages/react-core/src/components/Skeleton/examples/Skeleton.md index 1987422559f..0062ad91380 100644 --- a/packages/react-core/src/components/Skeleton/examples/Skeleton.md +++ b/packages/react-core/src/components/Skeleton/examples/Skeleton.md @@ -9,7 +9,7 @@ propComponents: ['Skeleton'] ### Default -```ts file="./SkeletonBasic.tsx" +```ts file="./SkeletonDefault.tsx" ``` ### Percentage widths diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx deleted file mode 100644 index 846b42d0ef8..00000000000 --- a/packages/react-core/src/components/Skeleton/examples/SkeletonBasic.tsx +++ /dev/null @@ -1,4 +0,0 @@ -import React from 'react'; -import { Skeleton } from '@patternfly/react-core'; - -export const SkeletonBasic: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonDefault.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonDefault.tsx new file mode 100644 index 00000000000..47d75fa63b7 --- /dev/null +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonDefault.tsx @@ -0,0 +1,4 @@ +import React from 'react'; +import { Skeleton } from '@patternfly/react-core'; + +export const SkeletonDefault: React.FunctionComponent = () => ; diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx index 6ca74b757fc..3f19887aa94 100644 --- a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageHeight.tsx @@ -3,11 +3,11 @@ import { Skeleton } from '@patternfly/react-core'; export const SkeletonPercentageHeight: React.FunctionComponent = () => (
- - - - - - + + + + + +
); diff --git a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx index 1e40d2c8d9a..39ca9ae7bd2 100644 --- a/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx +++ b/packages/react-core/src/components/Skeleton/examples/SkeletonPercentageWidth.tsx @@ -3,15 +3,15 @@ import { Skeleton } from '@patternfly/react-core'; export const SkeletonPercentageWidth: React.FunctionComponent = () => ( - +
- +
- +
- +
- +