From 6768ce1852761e145cbbbbdb1106148b06e53185 Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Thu, 9 Feb 2023 09:46:15 -0500 Subject: [PATCH 1/2] fix(Table): fix tooltips not appearing --- packages/react-table/src/components/TableComposable/Td.tsx | 3 +-- packages/react-table/src/components/TableComposable/Th.tsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react-table/src/components/TableComposable/Td.tsx b/packages/react-table/src/components/TableComposable/Td.tsx index f38a586966c..91a0be1fece 100644 --- a/packages/react-table/src/components/TableComposable/Td.tsx +++ b/packages/react-table/src/components/TableComposable/Td.tsx @@ -96,8 +96,7 @@ const TdBase: React.FunctionComponent = ({ ...props }: TdProps) => { const [showTooltip, setShowTooltip] = React.useState(false); - const cellRef = innerRef ? innerRef : React.createRef(); - + const cellRef = innerRef || React.createRef(); const onMouseEnter = (event: any) => { if (event.target.offsetWidth < event.target.scrollWidth) { !showTooltip && setShowTooltip(true); diff --git a/packages/react-table/src/components/TableComposable/Th.tsx b/packages/react-table/src/components/TableComposable/Th.tsx index 8b768c6da1f..b408c94000b 100644 --- a/packages/react-table/src/components/TableComposable/Th.tsx +++ b/packages/react-table/src/components/TableComposable/Th.tsx @@ -79,7 +79,7 @@ const ThBase: React.FunctionComponent = ({ ...props }: ThProps) => { const [showTooltip, setShowTooltip] = React.useState(false); - const cellRef = innerRef ? innerRef : React.createRef(); + const cellRef = innerRef || React.createRef(); const onMouseEnter = (event: any) => { if (event.target.offsetWidth < event.target.scrollWidth) { !showTooltip && setShowTooltip(true); From 2c6182387949c479d0d21a3d892f34c026da743a Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Mon, 20 Feb 2023 17:32:05 -0500 Subject: [PATCH 2/2] updates --- packages/react-table/src/components/TableComposable/Td.tsx | 2 +- packages/react-table/src/components/TableComposable/Th.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-table/src/components/TableComposable/Td.tsx b/packages/react-table/src/components/TableComposable/Td.tsx index 91a0be1fece..1c3548b5bdb 100644 --- a/packages/react-table/src/components/TableComposable/Td.tsx +++ b/packages/react-table/src/components/TableComposable/Td.tsx @@ -96,7 +96,7 @@ const TdBase: React.FunctionComponent = ({ ...props }: TdProps) => { const [showTooltip, setShowTooltip] = React.useState(false); - const cellRef = innerRef || React.createRef(); + const cellRef = innerRef ? innerRef : React.createRef(); const onMouseEnter = (event: any) => { if (event.target.offsetWidth < event.target.scrollWidth) { !showTooltip && setShowTooltip(true); diff --git a/packages/react-table/src/components/TableComposable/Th.tsx b/packages/react-table/src/components/TableComposable/Th.tsx index b408c94000b..8b768c6da1f 100644 --- a/packages/react-table/src/components/TableComposable/Th.tsx +++ b/packages/react-table/src/components/TableComposable/Th.tsx @@ -79,7 +79,7 @@ const ThBase: React.FunctionComponent = ({ ...props }: ThProps) => { const [showTooltip, setShowTooltip] = React.useState(false); - const cellRef = innerRef || React.createRef(); + const cellRef = innerRef ? innerRef : React.createRef(); const onMouseEnter = (event: any) => { if (event.target.offsetWidth < event.target.scrollWidth) { !showTooltip && setShowTooltip(true);