From 0c75d2ba70d637f2992c5be9d45666e803fcb971 Mon Sep 17 00:00:00 2001 From: adamviktora Date: Mon, 13 Feb 2023 10:21:26 +0100 Subject: [PATCH 1/2] fix(MenuGroup): do not set id when titleId prop isn't passed remove default titleId prop value, so id is not being set everytime closes #8162 BREAKING CHANGE --- packages/react-core/src/components/Menu/MenuGroup.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-core/src/components/Menu/MenuGroup.tsx b/packages/react-core/src/components/Menu/MenuGroup.tsx index 689891a8211..b1ee09e340b 100644 --- a/packages/react-core/src/components/Menu/MenuGroup.tsx +++ b/packages/react-core/src/components/Menu/MenuGroup.tsx @@ -21,7 +21,7 @@ const MenuGroupBase: React.FunctionComponent = ({ children, className = '', label = '', - titleId = '', + titleId, innerRef, labelHeadingLevel: HeadingLevel = 'h1', ...props From bfedf8423de21cef6fc391adfd53954b0542d59a Mon Sep 17 00:00:00 2001 From: adamviktora Date: Mon, 13 Feb 2023 15:57:31 +0100 Subject: [PATCH 2/2] fix(MenuGroup): update dependencies v5 @patternfly/react-core alpha version --- packages/react-integration/demo-app-ts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-integration/demo-app-ts/package.json b/packages/react-integration/demo-app-ts/package.json index 389db37a562..2459394eef9 100644 --- a/packages/react-integration/demo-app-ts/package.json +++ b/packages/react-integration/demo-app-ts/package.json @@ -9,7 +9,7 @@ "serve:demo-app": "node scripts/serve" }, "dependencies": { - "@patternfly/react-core": "^5.0.0-alpha.10", + "@patternfly/react-core": "^5.0.0-alpha.11", "react": "^18", "react-dom": "^18", "react-router": "^5.3.3",